fix: cluster id store as undefined in createInstance request (googlea…

…pis#654) * fix: cluster id store as undefined
feywind · Mar 23, 2020 · 809c719 · 809c719
1 parent 69839cd
commit 809c719
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -641,6 +641,12 @@ export class Bigtable {
     }
 
     reqOpts.clusters = arrify(options.clusters!).reduce((clusters, cluster) => {
+      if (!cluster.id) {
+        throw new Error(
+          'A cluster was provided without an `id` property defined.'
+        );
+      }
+
       clusters[cluster.id!] = {
         location: Cluster.getLocation_(this.projectId, cluster.location!),
         serveNodes: cluster.nodes,

diff --git a/test/index.ts b/test/index.ts
@@ -489,6 +489,23 @@ describe('Bigtable', () => {
         done();
       });
     });
+
+    it('should throw an error if cluster id not provided.', () => {
+      const options = {
+        displayName: 'my-sweet-instance',
+        labels: {env: 'prod'},
+        clusters: [
+          {
+            nodes: 3,
+            location: 'us-central1-b',
+            storage: 'ssd',
+          },
+        ],
+      };
+      assert.throws(() => {
+        bigtable.createInstance(INSTANCE_ID, options);
+      }, /A cluster was provided without an `id` property defined\./);
+    });
   });
 
   describe('getInstances', () => {