Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update mainnet almanac registration fees #636

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Feb 19, 2025

Proposed Changes

Query contract for Almanac registration fees.

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated the documentation (executed the script in python/scripts/generate_api_docs.py)

@jrriehl jrriehl requested a review from MissingNO57 February 19, 2025 15:44
@jrriehl jrriehl marked this pull request as draft February 19, 2025 15:54
@Archento
Copy link
Member

It feels like we can summarise a lot of the fee checks into a single configuration value but I haven't checked if that is feasible. Just one thing that came to my mind when looking at the PR.

@jrriehl jrriehl marked this pull request as ready for review February 19, 2025 16:06
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I had in mind :) LGTM!

@jrriehl jrriehl merged commit 88083a9 into main Feb 19, 2025
10 checks passed
@jrriehl jrriehl deleted the chore/update-mainnet-almanac-registration-fees branch February 19, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants