Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support for Ledger Nano S-Plus (ledger-go v0.9.3) #169

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

pbukva
Copy link
Contributor

@pbukva pbukva commented Sep 19, 2023

No description provided.

go.mod Outdated
Comment on lines 51 to 52
google.golang.org/grpc v1.50.1
google.golang.org/protobuf v1.28.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth isolating these changes from the ledger-go side of things or is does this come as a package 😁

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #169 (349a3ad) into main (43f6e51) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   60.51%   60.51%           
=======================================
  Files         599      599           
  Lines       38884    38884           
=======================================
  Hits        23532    23532           
  Misses      13372    13372           
  Partials     1980     1980           
Files Changed Coverage Δ
x/mint/abci.go 0.00% <0.00%> (ø)
x/mint/keeper/grpc_query.go 56.25% <0.00%> (ø)

@pbukva pbukva changed the title fix: Support for Ledger Nano S-Plus (ledger-cosmos-go v0.12.0) fix: Support for Ledger Nano S-Plus (ledger-go v0.9.3) Sep 20, 2023
Copy link
Collaborator

@MissingNO57 MissingNO57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbukva pbukva merged commit 5c32260 into fetchai:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants