Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Municipal Inflation MVP #153

Merged
merged 32 commits into from
Jun 30, 2023
Merged

feat: Municipal Inflation MVP #153

merged 32 commits into from
Jun 30, 2023

Conversation

Jonathansumner
Copy link
Member

@Jonathansumner Jonathansumner commented Jun 30, 2023 •
edited by pbukva
Loading

Introduces Municiple Inflation, allowing native tokens to have individually specified inflation rates and 'fee-collector' accounts.

  • Each of these MunicipalInflation objects will be used to inflate the relevant supply - new tokens will be issued on to the target_address address on per-block bases.
  • Includes a number of tests providing coverage to this new mechanism.

This PR is just re-submission of the original PR #150(which have been reverted using reset & forced push of the main branch) in order to correct resulting git commit message.

Jonathansumner and others added 30 commits June 12, 2023 17:42
@Jonathansumner
fix: improve makefile
443e9ae
@Jonathansumner
fix: amend protobuf config versioning
bcd1e58
@Jonathansumner
fix: add linter dependencies
a191318
@Jonathansumner
chore: add exceptions for OTT lint rules
516eaf5
@Jonathansumner
chore: linting
8f4db6f
@Jonathansumner
feat: initial native inflations infrastructure
a115655
@Jonathansumner
Merge branch 'fix/improve-makefile' of github.com:fetchai/cosmos-sdk …
1646d8a 
…into feat/inflation-infrastructure
@Jonathansumner
fix: amend query params
6f6a314
@Jonathansumner
test: construct basic skeleton of inflations testing suite
aa19e22
@Jonathansumner
fix: amend inflation logic
c9523ed
@Jonathansumner
test: include coverage of inflations validation
f5cde11 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
chore: tidy up
69ee2b3 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
fix: amend inflation calc
eb0b6f2 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
refact: split large handleInflations calculation up
6d2a69b 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
chore: simplify inflations_test.go
b65c222 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
chore: make handleInflations trigger each block
486a0e6 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
chore: temporarily disable depsguard linter
3eb8e4e 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
test: extend coverage to inflation calc precision & time
8986b02 
Signed-off-by: jonathansumner <[email protected]>
@pbukva
Fixing circular dependency issue in inflation_test.go
5d8cc8b
@Jonathansumner
test: improve test coverage
f1f68e2 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
Merge remote-tracking branch 'origin/feat/inflation-infrastructure' i…
304134d 
…nto feat/inflation-infrastructure

# Conflicts:
#	x/mint/types/inflations_test.go
@Jonathansumner
fix: amend targetAddress conversion
0425afd 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
chore: remove unnecessary transfers during test
626853f 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
fix: fix inflation precision test & add inflation caching
8594f20 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
refact: amend inflationCalc test to actually use handleInflations func
98716ac 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
Merge branch 'main' of github.com:fetchai/cosmos-sdk into feat/inflat…
8b2eb80 
…ion-infrastructure
@Jonathansumner
chore: return errors from func instead of panic
b92b994 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
test: include inflations gRPC query test
6cc87af 
Signed-off-by: jonathansumner <[email protected]>
@Jonathansumner
test: include grpc querying tests for inflations
5413370 
Signed-off-by: jonathansumner <[email protected]>
@pbukva
Refactoring & uTests update
a1e3fcf
@Jonathansumner Jonathansumner requested a review from pbukva June 30, 2023 12:09
@Jonathansumner Jonathansumner self-assigned this Jun 30, 2023
@pbukva pbukva changed the title feat: initial municipal inflation Municipal Inflation MVP Jun 30, 2023
pbukva
pbukva approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (please see the original PR #150 for more details)

@pbukva pbukva changed the title Municipal Inflation MVP feat: Municipal Inflation MVP Jun 30, 2023
@Jonathansumner Jonathansumner merged commit 0c003df into main Jun 30, 2023
@Jonathansumner Jonathansumner deleted the feat/municipal-inflation-mvp branch June 30, 2023 12:21
@Jonathansumner Jonathansumner restored the feat/municipal-inflation-mvp branch July 21, 2023 16:21
pbukva added a commit that referenced this pull request Aug 12, 2023
@Jonathansumner @pbukva
feat: Municipal Inflation (#162)
43f6e51 
* feat: Municipal Inflation MVP (#153)

* fix: Municipal Inflation: list->map & cli command printout (#154)

* fix: Municipal Inflation: grpc query error check (#155)

* fix: Municipal Inflation: cli tests for query with denom (#156)

* fix: [WIP] Municipal Inflation determinism(map->list), cache redesign (#159)

* [Cosmetic]: Municipal Inflation Cache: update code comment (#163)

* fix: [Cosmetic] Go linting (#164)

* fix: [Cosmetic] Go linting
* CI test run - setting golang v1.18.10

* fix: Municipal Inflation: protobuf yaml tag naming (#165)

* fix: Municipal Inflation: cache redesign atomic + simtest (#166)

* feat: Municipal Inflation: Handler optimisation & Validation fix (#167)

---------

Co-authored-by: void* <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbukva pbukva pbukva approved these changes

Assignees

@Jonathansumner Jonathansumner

Labels
C:CLI C:Simulations C:x/mint C:x/staking Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonathansumner @pbukva