feat(oci/client.rs): add registry_from_input helper #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
feat/login-registry-from-input
branch
from
0d23a22 to
72f4343
Compare
itowlson
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper to hold parsing logic around converting the user-supplied registry server into a form compatible with the underlying oci library. This helper also includes logic to avoid the failure mode for
spin registry login docker.iowhich would previously error out with an unhelpful message.**Note, although the underlying oci-distribution library has a similar helper, it uses a qualified Reference (eg
docker.io/ubuntu:latest) which the provided server string is not, as it only represents the registry portion. Hence using our own logic here.