Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): Bump Spin dependency to v2.4.0 #19

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

radu-matei
Copy link
Member

This commit bumps the Spin dependency to v2.4.0, and addresses the changes in
the trigger trait.

Signed-off-by: Radu Matei [email protected]

@radu-matei radu-matei force-pushed the chore/bump-spin-v2.4.0 branch from 80eacee to 8e173e5 Compare March 29, 2024 12:29
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump is fine, but if we're adopting cargo fmt on this repo, then I'd prefer to do it as a separate PR as we should also add enforcement in CI etc. (I'm happy that we do it... just how we do it!)

@radu-matei radu-matei force-pushed the chore/bump-spin-v2.4.0 branch from 8e173e5 to 0af064e Compare April 2, 2024 08:13
@radu-matei
Copy link
Member Author

Only kept the version bumps in this PR. Thanks!

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radu-matei!

@itowlson itowlson merged commit da89f1e into fermyon:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants