Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug with _transient gobal variable #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seismicmike
Copy link

Hi!

I've been using your nusoap package from Packagist for a while now and it's worked pretty well for me. Today, I came across a weird issue. I was getting an error about an undefined index "_transient". I googled and came up with http://stackoverflow.com/questions/14607718/multiple-nusoap-clients-causes-undefined-index-transient-error

Apparently somebody called Scardetto had already patched this in their fork of nusoap but rather than trying to somehow trace that back to something that I could use with composer, I just decided to fork and patch your code.

So anyway, I figured I'd send this back upstream in case you're intreested. Here's the patch. You can pretty much ignore the changes to .gitignore, README, composer.json, etc.The material change is in lib/class.nusoap_base.php

Let me know if you have any questions.
Thanks

@williamorazi
Copy link

I've been coming across this error when using PHPUnit with the backupGlobals configuration value set to TRUE. Disabling this configuration setting resolves the error being generated. Not sure why this isn't simply a static property to avoid this issue.

@seismicmike
Copy link
Author

seismicmike commented May 4, 2016

Interesting. I don't recall having any problems with this outside the PHPUnit context, so that's probably the culprit. I'll test with that disabled sometime and see if it makes a difference.

Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants