fix tests on windows

[TimeForANinja]

No description provided.

[codecov]

Codecov Report

Merging #318 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #318   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         594    594           
  Branches      148    148           
=====================================
  Hits          594    594

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f9cc2...ee60c5e. Read the comment docs.

[TimeForANinja]

should maybe also describe it a bit
running it produces an error on windows:

basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")
          ^^^^^^^

SyntaxError: missing ) after argument list

the solution can be found here:
gotwarlost/istanbul#677

[fent]

Do you know if changing from node_modules/mocha/bin/_mocha to just mocha would also work?

[TimeForANinja]

does not look like that works

C:\Users\\Documents\GitHub\node-ytdl-core>npm test

> ytdl-core@0.20.3 test C:\Users\\Documents\GitHub\node-ytdl-core
> istanbul cover mocha -- -t 16000 test/*-test.js

No coverage information was collected, exit without writing coverage information
C:\Users\\Documents\GitHub\node-ytdl-core\node_modules\.bin\mocha.CMD:1
(function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
                                                              ^

SyntaxError: Invalid or unexpected token
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:152:10)
    at Module._compile (module.js:605:28)
    at Object.Module._extensions..js (module.js:652:10)
    at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\\Documents\GitHub\node-ytdl-core\node_modules\istanbul\lib\hook.js:109:37)
    at Module.load (module.js:560:32)
    at tryModuleLoad (module.js:503:12)
    at Function.Module._load (module.js:495:3)
    at Function.Module.runMain (module.js:682:10)
    at runFn (C:\Users\\Documents\GitHub\node-ytdl-core\node_modules\istanbul\lib\command\common\run-with-cover.js:122:16)
npm ERR! Test failed.  See above for more details.```

[fent]

Thanks!

Looks like I'll have to update other repos that use a similar path too.

[TimeForANinja]

Np
Interesting how uncommon windows seems to be