Add support for custom wrapping for dialects #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default wrapping for identifiers is double quotes. However, the MySQL dialect uses backticks. This changes the mock client to use the custom wrapping implementation of the dialect, if one exists.
|
Did you tried to pass |
|
@felixmosh See #19 for the issue. This PR fixes the issue by using the custom implementation for wrapping identifiers, if the dialect provides one. |
|
Thank you for the PR 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default wrapping for identifiers is double quotes. However, the MySQL dialect uses backticks.
This changes the mock client to use the custom wrapping implementation of the dialect, if one exists.
Fixes #19.