fix panic: divide by zero #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simakvladimir
force-pushed
the
fix-div-on-zero-panic
branch
from
e0dc90a to
64aac35
Compare
simakvladimir
force-pushed
the
fix-div-on-zero-panic
branch
from
64aac35 to
f8eab7e
Compare
|
@felixge sorry to interrupt, but could you review PR, please? |
|
Same error. Pls fix. |
|
Fix LGTM. For now I work around with a |
klauspost
added a commit
to klauspost/minio
that referenced
this pull request
Jan 3, 2025
Using admin traces could potentially crash the server (or handler more likely) due to upstream divide by 0: felixge/fgprof#34 Ensure the profile always runs 100ms before stopping, so sample count isn't 0 (default sample rate ~10ms/sample, but allow for cpu starvation)
1 task
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Jan 6, 2025
Add profiling potential crash wourkaround Using admin traces could potentially crash the server (or handler more likely) due to upstream divide by 0: felixge/fgprof#34 Ensure the profile always runs 100ms before stopping, so sample count isn't 0 (default sample rate ~10ms/sample, but allow for cpu starvation)
harshavardhana
pushed a commit
to minio/minio
that referenced
this pull request
Mar 17, 2025
Add profiling potential crash wourkaround Using admin traces could potentially crash the server (or handler more likely) due to upstream divide by 0: felixge/fgprof#34 Ensure the profile always runs 100ms before stopping, so sample count isn't 0 (default sample rate ~10ms/sample, but allow for cpu starvation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thx for the great tool!
Problem
In production we use fgprof + alloy + pyroscope. Sometimes we catch panic:
Same problem described here.
Panic reproduced in tests when stop called straight after start without sleep.
Possible solution
Check pprof sampling rate on zero before exportPprof calling.