modules/contrib/bootupd: Remove module #2145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe also need to remove selinux-policy/policy/modules.conf Lines 3117 to 3122 in 351a598 which was from d4da143 |
Bootupd is no longer using a systemd service and socket unit. It is now called either directly from the command line by an administrator or in the furture as part of the boot process in a oneshot unit. See: coreos/bootupd#551
travier
force-pushed
the
rawhide-rm-bootupd
branch
from
8ad8753 to
e1d2073
Compare
|
To be paired with https://src.fedoraproject.org/rpms/selinux-policy/pull-request/431 |
|
@travier I am afraid we are not going to make such a change without any serious justification. Having not confined service violates a DISA STIG rule which customers require, and using systemd-run means it runs as a service. Running from cli makes the policy not user, but it also cannot clash with it. If there are any particular problems, please report it so that we can work on a fix. |
|
Well, it's not really a service, it only runs under systemd-run to get an isolated environment. We don't confine every single mkfs calls with SELinux for example. It's only available to root and we expect that to be the constraint. |
|
Turns out we do! |
|
But we don't do it for |
|
We could keep this module, but it needs work as how it is written right now likely does not work. |
It needs full writable access to |
|
And if remove the permissive mode, bootupd will not work as there are a lot of denied logs. |
|
@HuijingHei Can you paste those logs here? |
Sure, test with |
|
Great, if you could get the logs from an update as well that would be great. |
|
|
Create https://issues.redhat.com/browse/FC-1230 to track the denied logs. |
Note that there is probably nobody looking at this project as it's mostly mirrored issues from bugzilla. It should probably be a bugzilla instead. |
|
Closing for now. We'll do #2257 |
Thanks! New bug https://bugzilla.redhat.com/show_bug.cgi?id=2300306 to track the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootupd is no longer using a systemd service and socket unit.
It is now called either directly from the command line by an administrator or in the furture as part of the boot process in a oneshot unit.
See: coreos/bootupd#551