Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added health checks with flask-healthz #398

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

rod7760
Copy link
Contributor

@rod7760 rod7760 commented Oct 3, 2024

Resolves: #352

Signed-off-by: Riccardi Dalexis [email protected]

@rod7760 rod7760 force-pushed the add-flask-healthz branch from 39c8f09 to acfe02e Compare October 9, 2024 00:55
@rod7760
Copy link
Contributor Author

rod7760 commented Oct 9, 2024

I resolved the failing lint checks. My apologies.

Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! There's a possible improvement that I noted, but it's overall very good!

mirrormanager2/health_checks.py Outdated Show resolved Hide resolved
@rod7760 rod7760 force-pushed the add-flask-healthz branch 2 times, most recently from 7bee1d1 to d8327b8 Compare October 10, 2024 12:13
Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks again!

@abompard abompard merged commit 4aa8c86 into fedora-infra:master Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flask-healthz
2 participants