-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the list of banned users configurable Draft pull #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please also add the list to the fedbadges.toml.example
file.
Also, please squash your commits. |
I Cant get the commits to squash and I've tried a million things. I pretty shure I made it worse... lol |
OK I think I fixed the squashes :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I turned rules reload back to 15 from 1
.vscode/settings.json
Outdated
@@ -0,0 +1,3 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is unrelated to this PR, please don't add it.
fedbadges.toml.example
Outdated
|
||
# Users skipped when awarding badges | ||
skip_users = [ | ||
# Users skped when awarding badges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here.
fedbadges/rules.py
Outdated
|
||
# Remove None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't really need to add this empty line, comments are usually right above what they are commenting.
Looks like you've merged your local copy into the changed that I had made to this pull request, which added back all the commits including merge conflicts. |
0a7f114
to
87dac8d
Compare
The problem may be coming from the fact that the Git integration in VS Code is really basic and doesn't let you do advanced stuff without an additional plugin. In any case, please remember to check the "Files changed" section of a PR after you've pushed, to make sure the changes are exactly what you want in the PR and nothing else. |
Signed-off-by: Aurélien Bompard <[email protected]>
No description provided.