Rewrite seeing profile radial profile calculation #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cutout2D automatically handles things like the edge of an image and allows easy translation between cutout coordinates and coordinates on the original image.
Partially addresses feder-observatory#98 by adding a camera argument to profile finding Fixes feder-observatory#174 by using RadialProfile and CurveOfGrowth from photutils
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 54.44% 55.97% +1.52%
==========================================
Files 23 24 +1
Lines 2911 2973 +62
==========================================
+ Hits 1585 1664 +79
+ Misses 1326 1309 -17 ☔ View full report in Codecov by Sentry. |
JuanCab
reviewed
Jan 1, 2024
| with self.out: | ||
| # sub_med += med | ||
| with self.seeing_profile_plot: | ||
| r_exact, individual_counts = rad_prof.pixel_values_in_profile |
There was a problem hiding this comment.
Is there a reason you moved these variables (r_exact and scaled_exact_counts) out of the rad_prof instance?
stellarphot/photometry/profiles.py
Outdated
|
|
||
| class CenterAndProfile: | ||
| """ | ||
| Class to dentermine center of and hold radial profile information for a star. |
There was a problem hiding this comment.
unless you are planning to really make code that bites, you want to 'determine center' not 'dentermine center' :)
JuanCab
reviewed
Jan 1, 2024
3 tasks
JuanCab
reviewed
Jan 4, 2024
JuanCab
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the radial profile calculation from seeing_profile_functions into a class that makes use of relatively new functionality in photutils for finding radial profiles.
The radial profiling class was added to the
photometrysub-package but could go somewhere else I suppose.One subsequent change to the
SeeingProfileWidgetwill be to move the plotting functionality into theplottingsubpackage.