Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackify code #214

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Blackify code #214

merged 3 commits into from
Dec 16, 2023

Conversation

mwcraig
Copy link
Contributor

@mwcraig mwcraig commented Dec 15, 2023

This PR

  • Formats the code with black
  • Adds black configuration
  • Adds a pre-commit hook for black
  • Ignores the commit in which the code was reformatted for the purposes of git blame

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 402 lines in your changes are missing coverage. Please review.

Comparison is base (2eb4fcb) 53.28% compared to head (519e267) 53.28%.
Report is 1 commits behind head on main.

Files Patch % Lines
stellarphot/gui_tools/comparison_functions.py 6.31% 89 Missing ⚠️
stellarphot/gui_tools/seeing_profile_functions.py 30.00% 42 Missing ⚠️
stellarphot/transit_fitting/core.py 9.30% 39 Missing ⚠️
stellarphot/io/aij.py 44.77% 37 Missing ⚠️
stellarphot/photometry/photometry.py 79.20% 26 Missing ⚠️
stellarphot/plotting/multi_night_plots.py 10.71% 25 Missing ⚠️
stellarphot/utils/magnitude_transforms.py 56.86% 22 Missing ⚠️
stellarphot/transit_fitting/gui.py 47.50% 21 Missing ⚠️
stellarphot/plotting/transit_plots.py 5.00% 19 Missing ⚠️
stellarphot/io/tess.py 41.37% 17 Missing ⚠️
... and 11 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   53.28%   53.28%           
=======================================
  Files          24       24           
  Lines        2877     2877           
=======================================
  Hits         1533     1533           
  Misses       1344     1344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig
Copy link
Contributor Author

mwcraig commented Dec 16, 2023

I don't think the coverage change is meaningful -- we have increased the number of lines of code a bit by blackifying it, which reduces the coverage when measured by number of lines covered. black promises not to change the functioning of the code, so it seems safe to assume this hasn't added new problems.

@mwcraig
Copy link
Contributor Author

mwcraig commented Dec 16, 2023

@JuanCab -- this may now automatically apply black to new commits once you have pulled the latest version of the repo. Not 100% sure yet.

@mwcraig mwcraig merged commit b35dcf9 into feder-observatory:main Dec 16, 2023
8 of 9 checks passed
@mwcraig mwcraig deleted the blackify-code-2 branch February 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant