Merge pull request #248 from mwcraig/fix-linting-gui-tools

Fix linting gui tools

pyproject.toml

@@ -122,7 +122,6 @@ select = [
 "docs/conf.py" = ["F405"]
 
 # Ignore pyflakes and ARGS issues in each subpackage until they are fixed
-"stellarphot/gui_tools/*" = ["F", "ARG"]
 "stellarphot/utils/*" = ["F", "ARG"]
 
 [tool.pytest.ini_options]

stellarphot/gui_tools/comparison_functions.py

@@ -17,8 +17,6 @@
     from astrowidgets.ginga import ImageWidget
 
 from stellarphot import SourceListData
-from stellarphot.differential_photometry import *
-from stellarphot.photometry import *
 from stellarphot.gui_tools.seeing_profile_functions import set_keybindings
 from stellarphot.gui_tools.fits_opener import FitsOpener
 from stellarphot.io import TessSubmission, TOI, TessTargetFile
@@ -127,9 +125,7 @@ def cb(viewer, event, data_x, data_y):  # noqa: ARG001
             imagewidget.next_elim += 1
         except AttributeError:
             imagewidget.next_elim = 1
-        pad = 15
-        x = int(np.floor(event.data_x))
-        y = int(np.floor(event.data_y))
+
         ra, dec = i.wcs.wcs.all_pix2world(event.data_x, event.data_y, 0)
         out_skycoord = SkyCoord(ra=ra, dec=dec, unit=(u.degree, u.degree))
 

stellarphot/gui_tools/seeing_profile_functions.py

@@ -227,15 +227,9 @@ def __init__(self, imagewidget=None, width=500, camera=None):
         self._set_observers()
         self.aperture_settings.description = ""
 
-    def load_fits(self, file):
+    def load_fits(self):
         """
         Load a FITS file into the image widget.
-
-        Parameters
-        ----------
-
-        file : str
-            Filename to open.
         """
         self.fits_file.load_in_image_widget(self.iw)
         self.object_name = self.fits_file.object
@@ -250,8 +244,9 @@ def load_fits(self, file):
             )
             self.exposure = np.nan
 
-    def _update_file(self, change):
-        self.load_fits(change.selected)
+    def _update_file(self, change):  # noqa: ARG002
+        # Widget callbacks need to accept a single argument, even if it is not used.
+        self.load_fits()
 
     def _construct_tess_sub(self):
         file = self.fits_file.path
@@ -341,8 +336,8 @@ def _update_ap_settings(self, value):
 
     def _make_show_event(self):
         def show_event(
-            viewer, event=None, datax=None, datay=None, aperture=None
-        ):  # noqa: ARG001
+            viewer, event=None, datax=None, datay=None, aperture=None  # noqa: ARG001
+        ):
             """
             ginga callbacks require the function signature above.
             """
@@ -409,7 +404,6 @@ def show_event(
     def _update_plots(self):
         # DISPLAY THE SCALED PROFILE
         fig_size = (10, 5)
-        profile_size = 60
 
         rad_prof = self.rad_prof
         self.seeing_profile_plot.clear_output(wait=True)

stellarphot/gui_tools/tests/test_seeing_profile.py

@@ -1,4 +1,3 @@
-from astropy.table import Table
 from astrowidgets import ImageWidget
 
 from stellarphot.gui_tools import seeing_profile_functions as spf