Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block merging PRs with test cases failures #1064

Merged
merged 32 commits into from
Feb 15, 2023
Merged

Block merging PRs with test cases failures #1064

merged 32 commits into from
Feb 15, 2023

Conversation

enya-yx
Copy link
Collaborator

@enya-yx enya-yx commented Feb 13, 2023 •
edited
Loading

Description

  • Block merging PRs if they can trigger any test case failures for scala, synapse, databricks, and registry
  • Add a 'test_status' to check CI test results
  • Fix a bug in data source

How was this PR tested?

Does this PR introduce any user-facing changes?

  • No. You can skip the rest of this section.
  • Yes. Make sure to clarify your proposed changes.

@enya-yx enya-yx added the safe to test Tag to execute build pipeline for a PR from forked repo label Feb 13, 2023
blrchen
blrchen previously approved these changes Feb 14, 2023
View reviewed changes
Yuqing-cat
Yuqing-cat previously approved these changes Feb 14, 2023
View reviewed changes
@enya-yx enya-yx dismissed stale reviews from Yuqing-cat and blrchen via b4f280f February 14, 2023 09:11
@enya-yx enya-yx removed the safe to test Tag to execute build pipeline for a PR from forked repo label Feb 14, 2023
@enya-yx enya-yx changed the title [Do Not Merge] Block merging PRs with test cases failures Block merging PRs with test cases failures Feb 15, 2023
@enya-yx enya-yx added safe to test Tag to execute build pipeline for a PR from forked repo registry test Used to run test cases for registry labels Feb 15, 2023
@blrchen
Copy link
Collaborator

blrchen commented Feb 15, 2023

LKTM, thanks for the PR. I think we might need to enable a new bot in further, whcih automatically add 'secure' label for all PRs from people in controbutor role.

@blrchen blrchen merged commit 18d6e4c into feathr-ai:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoyongzhu xiaoyongzhu xiaoyongzhu approved these changes

@blrchen blrchen blrchen approved these changes

@Yuqing-cat Yuqing-cat Yuqing-cat left review comments

Assignees
No one assigned
Labels
registry test Used to run test cases for registry safe to test Tag to execute build pipeline for a PR from forked repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enya-yx @blrchen @xiaoyongzhu @Yuqing-cat