chore: Upgrade Jest packages to latest versions in /ui #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is preparatory work to upgrade msw, which proved out to be
impossible to do (at least for me) with older versions of Jest.
Notes about the changes:
- The syntax for Jest transformers has changed, updated cssTransform.js
accordingly
- By default, we don't transform files in node_modules, but we now need
to transform a couple dependencies, so we need to un-ignore them in
`transformIgnorePatterns` in the Jest config:
- @elastic/eui uses CSS keywords not understood by Jest
- uuid is an ECMAScript module and needs to be transpiled to CommonJS
to be understood by Jest
- The transitive nwsapi dependency needs to be pinned to an older
version in package.json since the newest versions fail to parse some
CSS class names that Elastic UI generates. This workaround was
suggested in dperini/nwsapi#139 (comment)
Signed-off-by: Harri Lehtola <[email protected]>
redhatHameed
approved these changes
Jan 29, 2025
franciscojavierarceo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade Jest related packages to their latest versions. This is preparatory work to upgrade msw (whose old version causes security alerts due to vulnerable dependencies), which proved out to be impossible to do with older versions of Jest (at least for me). (I also tried switching from Jest to Vitest but had some mysterious failures with it too, may revisit it later.)
Which issue(s) this PR fixes:
None.
Misc
This was a long and winding road filled with desperation at times, so I should explain some changes:
cssTransform.jsaccordinglynode_modules, but we now need to transform a couple dependencies, so we need to un-ignore them intransformIgnorePatternsin the Jest config:@elastic/euiuses CSS keywords not understood by Jestuuidis an ECMAScript module and needs to be transpiled to CommonJS to be understood by Jestnwsapidependency needs to be pinned to an older version inpackage.jsonbecause the newest versions fail to parse some CSS class names that Elastic UI generates. This workaround was suggested in Invalid selector withinput:not([value=''])in 2.2.16 dperini/nwsapi#139 (comment)