chore: Moving Milvus client to PyMilvus #4907
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR moves the Milvus Online Store implementation to the PyMilvus Client instead of using Connections, in addition to some other minor changes.
More specifically:
sdk/python/feast/feature_store.py
:distance_metric
parameter in theretrieve_online_documents
method to "L2".sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
:pymilvus.orm.connections
withMilvusClient
for managing Milvus connections.username
andpassword
configurations inMilvusOnlineStoreConfig
.MilvusOnlineStore
class to useMilvusClient
for creating and managing collections, including:username
andpassword
._connect
,_get_collection
,online_write_batch
,update
,teardown
, andretrieve_online_documents
to use the new client-based approach.sdk/python/tests/integration/feature_repos/universal/online_store/milvus.py
:MilvusContainer
withDockerContainer
fromtestcontainers.core
.sdk/python/tests/integration/online_store/test_universal_online.py
:Which issue(s) this PR fixes:
Another one in service of #4364
Misc
N/A