-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump macOS runners to macos-13 #4152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tokoko <[email protected]>
HaoXuAI
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Apr 30, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Apr 30, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
franciscojavierarceo
pushed a commit
that referenced
this pull request
Apr 30, 2024
…ll. (#4159) * Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> * Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> * chore: Bump macOS runners to macos-13 (#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * chore: Use pixi to lock python dependencies in a single command (#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * Trying to fix the lint error after python upgrade. - error: Call to abstract method "__init__" of "Provider" with trivial body via super() is unsafe [safe-super] Signed-off-by: Lokesh Rangineni <[email protected]> * Adding only the integration tests to run on 3.11 Signed-off-by: Lokesh Rangineni <[email protected]> --------- Signed-off-by: Lokesh Rangineni <[email protected]> Co-authored-by: Tornike Gurgenidze <[email protected]>
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
May 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]>
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
May 3, 2024
…ll. (feast-dev#4159) * Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> * Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> * chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * Trying to fix the lint error after python upgrade. - error: Call to abstract method "__init__" of "Provider" with trivial body via super() is unsafe [safe-super] Signed-off-by: Lokesh Rangineni <[email protected]> * Adding only the integration tests to run on 3.11 Signed-off-by: Lokesh Rangineni <[email protected]> --------- Signed-off-by: Lokesh Rangineni <[email protected]> Co-authored-by: Tornike Gurgenidze <[email protected]>
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
May 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]>
tmihalac
pushed a commit
to tmihalac/feast
that referenced
this pull request
May 3, 2024
…ll. (feast-dev#4159) * Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> * Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> * chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> * Trying to fix the lint error after python upgrade. - error: Call to abstract method "__init__" of "Provider" with trivial body via super() is unsafe [safe-super] Signed-off-by: Lokesh Rangineni <[email protected]> * Adding only the integration tests to run on 3.11 Signed-off-by: Lokesh Rangineni <[email protected]> --------- Signed-off-by: Lokesh Rangineni <[email protected]> Co-authored-by: Tornike Gurgenidze <[email protected]> Signed-off-by: Theodor Mihalache <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
May 24, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
franciscojavierarceo
pushed a commit
that referenced
this pull request
May 24, 2024
# [0.38.0](v0.37.0...v0.38.0) (2024-05-24) ### Bug Fixes * Add vector database doc ([#4165](#4165)) ([37f36b6](37f36b6)) * Change checkout action back to v3 from v5 which isn't released yet ([#4147](#4147)) ([9523fff](9523fff)) * Change numpy version <1.25 dependency to <2 in setup.py ([#4085](#4085)) ([2ba71ff](2ba71ff)), closes [#4084](#4084) * Changed the code the way mysql container is initialized. ([#4140](#4140)) ([8b5698f](8b5698f)), closes [#4126](#4126) * Correct nightly install command, move all installs to uv ([#4164](#4164)) ([c86d594](c86d594)) * Default value is not set in Redis connection string using environment variable ([#4136](#4136)) ([95acfb4](95acfb4)), closes [#3669](#3669) * Get container host addresses from testcontainers (java) ([#4125](#4125)) ([9184dde](9184dde)) * Get rid of empty string `name_alias` during feature view projection deserialization ([#4116](#4116)) ([65056ce](65056ce)) * Helm chart `feast-feature-server`, improve Service template name ([#4161](#4161)) ([dedc164](dedc164)) * Improve the code related to on-demand-featureview. ([#4203](#4203)) ([d91d7e0](d91d7e0)) * Integration tests for async sdk method ([#4201](#4201)) ([08c44ae](08c44ae)) * Make sure schema is used when calling `get_table_query_string` method for Snowflake datasource ([#4131](#4131)) ([c1579c7](c1579c7)) * Make sure schema is used when generating `from_expression` for Snowflake ([#4177](#4177)) ([5051da7](5051da7)) * Pass native input values to `get_online_features` from feature server ([#4117](#4117)) ([60756cb](60756cb)) * Pass region to S3 client only if set (Java) ([#4151](#4151)) ([b8087f7](b8087f7)) * Pgvector patch ([#4108](#4108)) ([ad45bb4](ad45bb4)) * Update doc ([#4153](#4153)) ([e873636](e873636)) * Update master-only benchmark bucket name due to credential update ([#4183](#4183)) ([e88f1e3](e88f1e3)) * Updating the instructions for quickstart guide. ([#4120](#4120)) ([0c30e96](0c30e96)) * Upgrading the test container so that local tests works with updated d… ([#4155](#4155)) ([93ddb11](93ddb11)) ### Features * Add a Kubernetes Operator for the Feast Feature Server ([#4145](#4145)) ([4a696dc](4a696dc)) * Add delta format to `FileSource`, add support for it in ibis/duckdb ([#4123](#4123)) ([2b6f1d0](2b6f1d0)) * Add materialization support to ibis/duckdb ([#4173](#4173)) ([369ca98](369ca98)) * Add optional private key params to Snowflake config ([#4205](#4205)) ([20f5419](20f5419)) * Add s3 remote storage export for duckdb ([#4195](#4195)) ([6a04c48](6a04c48)) * Adding DatastoreOnlineStore 'database' argument. ([#4180](#4180)) ([e739745](e739745)) * Adding get_online_features_async to feature store sdk ([#4172](#4172)) ([311efc5](311efc5)) * Adding support for dictionary writes to online store ([#4156](#4156)) ([abfac01](abfac01)) * Elasticsearch vector database ([#4188](#4188)) ([bf99640](bf99640)) * Enable other distance metrics for Vector DB and Update docs ([#4170](#4170)) ([ba9f4ef](ba9f4ef)) * Feast/IKV datetime edgecase errors ([#4211](#4211)) ([bdae562](bdae562)) * Feast/IKV documenation language changes ([#4149](#4149)) ([690a621](690a621)) * Feast/IKV online store contrib plugin integration ([#4068](#4068)) ([f2b4eb9](f2b4eb9)) * Feast/IKV online store documentation ([#4146](#4146)) ([73601e4](73601e4)) * Feast/IKV upgrade client version ([#4200](#4200)) ([0e42150](0e42150)) * Incorporate substrait ODFVs into ibis-based offline store queries ([#4102](#4102)) ([c3a102f](c3a102f)) * Isolate input-dependent calculations in `get_online_features` ([#4041](#4041)) ([2a6edea](2a6edea)) * Make arrow primary interchange for online ODFV execution ([#4143](#4143)) ([3fdb716](3fdb716)) * Move data source validation entrypoint to offline store ([#4197](#4197)) ([a17725d](a17725d)) * Upgrading python version to 3.11, adding support for 3.11 as well. ([#4159](#4159)) ([4b1634f](4b1634f)), closes [#4152](#4152) [#4114](#4114) ### Reverts * Reverts "fix: Using version args to install the correct feast version" ([#4112](#4112)) ([b66baa4](b66baa4)), closes [#3953](#3953)
franciscojavierarceo
pushed a commit
that referenced
this pull request
May 27, 2024
# [0.38.0](v0.37.0...v0.38.0) (2024-05-24) ### Bug Fixes * Add vector database doc ([#4165](#4165)) ([37f36b6](37f36b6)) * Change checkout action back to v3 from v5 which isn't released yet ([#4147](#4147)) ([9523fff](9523fff)) * Change numpy version <1.25 dependency to <2 in setup.py ([#4085](#4085)) ([2ba71ff](2ba71ff)), closes [#4084](#4084) * Changed the code the way mysql container is initialized. ([#4140](#4140)) ([8b5698f](8b5698f)), closes [#4126](#4126) * Correct nightly install command, move all installs to uv ([#4164](#4164)) ([c86d594](c86d594)) * Default value is not set in Redis connection string using environment variable ([#4136](#4136)) ([95acfb4](95acfb4)), closes [#3669](#3669) * Get container host addresses from testcontainers (java) ([#4125](#4125)) ([9184dde](9184dde)) * Get rid of empty string `name_alias` during feature view projection deserialization ([#4116](#4116)) ([65056ce](65056ce)) * Helm chart `feast-feature-server`, improve Service template name ([#4161](#4161)) ([dedc164](dedc164)) * Improve the code related to on-demand-featureview. ([#4203](#4203)) ([d91d7e0](d91d7e0)) * Integration tests for async sdk method ([#4201](#4201)) ([08c44ae](08c44ae)) * Make sure schema is used when calling `get_table_query_string` method for Snowflake datasource ([#4131](#4131)) ([c1579c7](c1579c7)) * Make sure schema is used when generating `from_expression` for Snowflake ([#4177](#4177)) ([5051da7](5051da7)) * Pass native input values to `get_online_features` from feature server ([#4117](#4117)) ([60756cb](60756cb)) * Pass region to S3 client only if set (Java) ([#4151](#4151)) ([b8087f7](b8087f7)) * Pgvector patch ([#4108](#4108)) ([ad45bb4](ad45bb4)) * Update doc ([#4153](#4153)) ([e873636](e873636)) * Update master-only benchmark bucket name due to credential update ([#4183](#4183)) ([e88f1e3](e88f1e3)) * Updating the instructions for quickstart guide. ([#4120](#4120)) ([0c30e96](0c30e96)) * Upgrading the test container so that local tests works with updated d… ([#4155](#4155)) ([93ddb11](93ddb11)) ### Features * Add a Kubernetes Operator for the Feast Feature Server ([#4145](#4145)) ([4a696dc](4a696dc)) * Add delta format to `FileSource`, add support for it in ibis/duckdb ([#4123](#4123)) ([2b6f1d0](2b6f1d0)) * Add materialization support to ibis/duckdb ([#4173](#4173)) ([369ca98](369ca98)) * Add optional private key params to Snowflake config ([#4205](#4205)) ([20f5419](20f5419)) * Add s3 remote storage export for duckdb ([#4195](#4195)) ([6a04c48](6a04c48)) * Adding DatastoreOnlineStore 'database' argument. ([#4180](#4180)) ([e739745](e739745)) * Adding get_online_features_async to feature store sdk ([#4172](#4172)) ([311efc5](311efc5)) * Adding support for dictionary writes to online store ([#4156](#4156)) ([abfac01](abfac01)) * Elasticsearch vector database ([#4188](#4188)) ([bf99640](bf99640)) * Enable other distance metrics for Vector DB and Update docs ([#4170](#4170)) ([ba9f4ef](ba9f4ef)) * Feast/IKV datetime edgecase errors ([#4211](#4211)) ([bdae562](bdae562)) * Feast/IKV documenation language changes ([#4149](#4149)) ([690a621](690a621)) * Feast/IKV online store contrib plugin integration ([#4068](#4068)) ([f2b4eb9](f2b4eb9)) * Feast/IKV online store documentation ([#4146](#4146)) ([73601e4](73601e4)) * Feast/IKV upgrade client version ([#4200](#4200)) ([0e42150](0e42150)) * Incorporate substrait ODFVs into ibis-based offline store queries ([#4102](#4102)) ([c3a102f](c3a102f)) * Isolate input-dependent calculations in `get_online_features` ([#4041](#4041)) ([2a6edea](2a6edea)) * Make arrow primary interchange for online ODFV execution ([#4143](#4143)) ([3fdb716](3fdb716)) * Move data source validation entrypoint to offline store ([#4197](#4197)) ([a17725d](a17725d)) * Upgrading python version to 3.11, adding support for 3.11 as well. ([#4159](#4159)) ([4b1634f](4b1634f)), closes [#4152](#4152) [#4114](#4114) ### Reverts * Reverts "fix: Using version args to install the correct feast version" ([#4112](#4112)) ([b66baa4](b66baa4)), closes [#3953](#3953)
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 3, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 6, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 6, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 12, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 12, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
lokeshrangineni
added a commit
to lokeshrangineni/feast
that referenced
this pull request
Jun 13, 2024
Signed-off-by: Lokesh Rangineni <[email protected]> Adding the integration test and remote online creator class so that it will fit into existing integration testing framework. Signed-off-by: Lokesh Rangineni <[email protected]> Fix after rebase Signed-off-by: Lokesh Rangineni <[email protected]> Removing the RemoteOnlineStoreCreator and adding custom integration test case. Incorporating the code review comments. Signed-off-by: Lokesh Rangineni <[email protected]> reformatting the code, removing unnecessary braces. Signed-off-by: Lokesh Rangineni <[email protected]> Trying to fix the errors reported in make lint-python Signed-off-by: Lokesh Rangineni <[email protected]> Ran the command make format-python and trying to see if it fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> increasing the server start timeout to see if it fixes the integration test cases. Signed-off-by: Lokesh Rangineni <[email protected]> checking changes after make format-python Signed-off-by: Lokesh Rangineni <[email protected]> trying to see if this fixes the PR integrationt test failure. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> checking in the changes for make format-python Signed-off-by: Lokesh Rangineni <[email protected]> Upgrading python version to 3.11, adding support for 3.11 as well. Signed-off-by: Lokesh Rangineni <[email protected]> chore: Bump macOS runners to macos-13 (feast-dev#4152) bump macos runner to 13 Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> chore: Use pixi to lock python dependencies in a single command (feast-dev#4114) use pixi to lock python dependencies in a single command Signed-off-by: tokoko <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]> feat: List all feature views (feast-dev#4256) * feature: Adding type to base feature view Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type and meta Signed-off-by: Francisco Javier Arceo <[email protected]> * adding new listing Signed-off-by: Francisco Javier Arceo <[email protected]> * updated Signed-off-by: Francisco Javier Arceo <[email protected]> * cleaning up changes Signed-off-by: Francisco Javier Arceo <[email protected]> * reverting FV proto Signed-off-by: Francisco Javier Arceo <[email protected]> * doing simple way Signed-off-by: Francisco Javier Arceo <[email protected]> * added a test Signed-off-by: Francisco Javier Arceo <[email protected]> * updated to add warnings Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> feat: Adding vector search for sqlite (feast-dev#4176) * feat: Adding vector search for sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * adding the sqlite_vss dependency Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading latest progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated function Signed-off-by: Francisco Javier Arceo <[email protected]> * adding configuration Signed-off-by: Francisco Javier Arceo <[email protected]> * adding current progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updating requirements files Signed-off-by: Francisco Javier Arceo <[email protected]> * moving to sqlite-vec Signed-off-by: Francisco Javier Arceo <[email protected]> * updating sqlite.py Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress Signed-off-by: Francisco Javier Arceo <[email protected]> * updated test type Signed-off-by: Francisco Javier Arceo <[email protected]> * got the initialization working, nice Signed-off-by: Francisco Javier Arceo <[email protected]> * checking in progress from last night Signed-off-by: Francisco Javier Arceo <[email protected]> * removing unnecessary stuff Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing merge conflicts Signed-off-by: Francisco Javier Arceo <[email protected]> * removing files changed accidentally] Signed-off-by: Francisco Javier Arceo <[email protected]> * uploading current progress...things run but need to update the virtual table insertion Signed-off-by: Francisco Javier Arceo <[email protected]> * linted Signed-off-by: Francisco Javier Arceo <[email protected]> * adding working notes Signed-off-by: Francisco Javier Arceo <[email protected]> * found a bug, original feature_store.py was only grabbing first feature view, adjusted Signed-off-by: Francisco Javier Arceo <[email protected]> * cant use a string have to verify it is a proper FeatureView object Signed-off-by: Francisco Javier Arceo <[email protected]> * updated got it working, need to fix some other stuff still Signed-off-by: Francisco Javier Arceo <[email protected]> * working Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * fixing some type issues Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed typing and lint issues Signed-off-by: Francisco Javier Arceo <[email protected]> * updated dependencies Signed-off-by: Francisco Javier Arceo <[email protected]> * fix for pixi and updating requirements Signed-off-by: Francisco Javier Arceo <[email protected]> * fixed type Signed-off-by: Francisco Javier Arceo <[email protected]> * linter Signed-off-by: Francisco Javier Arceo <[email protected]> * testing sqlite_vec import Signed-off-by: Francisco Javier Arceo <[email protected]> * adding minimal example test Signed-off-by: Francisco Javier Arceo <[email protected]> * lint Signed-off-by: Francisco Javier Arceo <[email protected]> * testing raw sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * Printing package version * printing version Signed-off-by: Francisco Javier Arceo <[email protected]> * updated requirements * rebuilding requirments Signed-off-by: Francisco Javier Arceo <[email protected]> * only going to run this on 3.10 for now Signed-off-by: Francisco Javier Arceo <[email protected]> * updated docs for sqlite caveats Signed-off-by: Francisco Javier Arceo <[email protected]> * adding reason Signed-off-by: Francisco Javier Arceo <[email protected]> * skipping Signed-off-by: Francisco Javier Arceo <[email protected]> * updated tests Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * added method call Signed-off-by: Francisco Javier Arceo <[email protected]> * added prubt Signed-off-by: Francisco Javier Arceo <[email protected]> * added print Signed-off-by: Francisco Javier Arceo <[email protected]> * removing print Signed-off-by: Francisco Javier Arceo <[email protected]> * adding check in sqlite Signed-off-by: Francisco Javier Arceo <[email protected]> * missed an = Signed-off-by: Francisco Javier Arceo <[email protected]> * still running on 3.11 Signed-off-by: Francisco Javier Arceo <[email protected]> * typo Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * fix Signed-off-by: Francisco Javier Arceo <[email protected]> * updated setup and docs Signed-off-by: Francisco Javier Arceo <[email protected]> * renamed things Signed-off-by: Francisco Javier Arceo <[email protected]> --------- Signed-off-by: Francisco Javier Arceo <[email protected]> squashing the last 15 commits to one. Merge branch 'master' into feature/adding-remote-onlinestore-rebase Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Adding documentation and incorporating code review comment. Signed-off-by: Lokesh Rangineni <[email protected]> Merge remote-tracking branch 'fork/feature/adding-remote-onlinestore-rebase' into feature/adding-remote-onlinestore-rebase Signed-off-by: Lokesh Rangineni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
macos runners are obviously slower than linux ones in the ci. We are using
macos-12
which is (3CPU/14RAM) whilelinux-latest
is (4CPU/16RAM). This PR bumps macos runner version to 13, which should be a similar image with 4 cores.