chore: Upgrade dask dependency #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
HaoXuAI
reviewed
Apr 15, 2024
| @@ -423,7 +423,7 @@ def _upload_entity_df_into_sqlserver_and_get_entity_schema( | |||
|
|
|||
| elif isinstance(entity_df, pandas.DataFrame): | |||
| # Drop the index so that we don't have unnecessary columns | |||
| engine.execute(_df_to_create_table_sql(entity_df, table_id)) | |||
| engine.execute(_df_to_create_table_sql(entity_df, table_id)) # type: ignore | |||
There was a problem hiding this comment.
Why suddenly adding the type ignore?
There was a problem hiding this comment.
not exactly sure tbh, but probably something related to this #4066. We broke mssql with sqlalchemy upgrade, it passed the ci, because we are not testing contribs in the ci. in other words, it's already broken with or without the type check.
franciscojavierarceo
approved these changes
Apr 16, 2024
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Apr 16, 2024
* add dataframe extra to dask Signed-off-by: tokoko <[email protected]> * update pinned versions Signed-off-by: tokoko <[email protected]> * add ignore rules to mssql, it's too broken Signed-off-by: tokoko <[email protected]> * ruff reformat Signed-off-by: tokoko <[email protected]> --------- Signed-off-by: tokoko <[email protected]>
lokeshrangineni
pushed a commit
to lokeshrangineni/feast
that referenced
this pull request
Apr 16, 2024
* add dataframe extra to dask Signed-off-by: tokoko <[email protected]> * update pinned versions Signed-off-by: tokoko <[email protected]> * add ignore rules to mssql, it's too broken Signed-off-by: tokoko <[email protected]> * ruff reformat Signed-off-by: tokoko <[email protected]> --------- Signed-off-by: tokoko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates
daskdependency and addsdataframeextra to dask. dask warnings should go away at last.