Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run tests as make commands in workflows #4035

Merged
merged 7 commits into from
Mar 27, 2024

Conversation

tokoko
Copy link
Collaborator

@tokoko tokoko commented Mar 23, 2024

What this PR does / why we need it:
As some workflows are marked as pull_request_target, it's hard to change the pytest command to run tests in a single PR. This PR changes workflows to run tests as make commands.

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@tokoko tokoko force-pushed the cleanup-workflows branch from f7bff0d to 13e7702 Compare March 24, 2024 11:43
Copy link
Collaborator

@sudohainguyen sudohainguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tokoko
Copy link
Collaborator Author

tokoko commented Mar 26, 2024

@franciscojavierarceo fyi, had to make some changes to stream_feature_view, typecheck was complaining about body_text of type string being passed to feature_transformation parameter. Not sure how this was missed in ci previously though, something about bumping library versions, i suppose.

@jeremyary
Copy link
Collaborator

This one's been soaking for a few days for feedback now. LGTM, I support pulling commands up and out of the action via leveraging make. Thanks!

@jeremyary jeremyary merged commit c364be4 into feast-dev:master Mar 27, 2024
14 checks passed
@tokoko tokoko deleted the cleanup-workflows branch March 27, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants