-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Run tests as make commands in workflows #4035
Conversation
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
Signed-off-by: tokoko <[email protected]>
f7bff0d
to
13e7702
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: tokoko <[email protected]>
@franciscojavierarceo fyi, had to make some changes to |
This one's been soaking for a few days for feedback now. LGTM, I support pulling commands up and out of the action via leveraging make. Thanks! |
What this PR does / why we need it:
As some workflows are marked as
pull_request_target
, it's hard to change the pytest command to run tests in a single PR. This PR changes workflows to run tests as make commands.