apply() method now works

Signed-off-by: Francisco Javier Arceo <[email protected]>
feast-dev · Dec 9, 2024 · 01c9a5f · 01c9a5f
1 parent 011ab46
commit 01c9a5f
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py b/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
@@ -77,14 +77,11 @@ def _get_collection(self, config: RepoConfig, table: FeatureView) -> Collection:
             self._connect(config)
 
             fields = [
-                FieldSchema(
-                    name="pk", dtype=DataType.INT64, is_primary=True, auto_id=True
-                ),
-                FieldSchema(name="entity_key", dtype=DataType.VARCHAR, max_length=512),
+                FieldSchema(name="entity_key", dtype=DataType.VARCHAR, max_length=512, is_primary=True),
                 FieldSchema(
                     name="feature_name", dtype=DataType.VARCHAR, max_length=256
                 ),
-                FieldSchema(name="value", dtype=DataType.BINARY_VECTOR, dim=8 * 1024),
+                # FieldSchema(name="value", dtype=DataType.BINARY_VECTOR, dim=8 * 1024),
                 FieldSchema(
                     name="vector_value",
                     dtype=DataType.FLOAT_VECTOR,
@@ -256,7 +253,7 @@ def teardown(
         for table in tables:
             collection_name = _table_id(config.project, table)
             collection = Collection(name=collection_name)
-            if collection.exists():
+            if collection:
                 collection.drop()
                 self._collections.pop(collection_name, None)