-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Haxe 3.3] Adds Support of -D display-stdin. closes #1311 #1318
Changes from 14 commits
f1b29e3
3ec5fe1
b00aeba
5641466
808e219
a80a61f
9ea4a28
9f80d32
ba6b810
17f7991
91023a1
88f114d
1ae181c
3592b9f
2f93efe
21bb147
7c68005
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
using System.Collections.Generic; | ||
using ASCompletion.Completion; | ||
using PluginCore; | ||
using PluginCore.Utilities; | ||
using ScintillaNet; | ||
|
||
namespace HaXeContext | ||
{ | ||
class HaxeComplete330 : HaxeComplete | ||
{ | ||
public HaxeComplete330(ScintillaControl sci, ASExpr expr, bool autoHide, IHaxeCompletionHandler completionHandler, HaxeCompilerService compilerService, SemVer haxeVersion) : base(sci, expr, autoHide, completionHandler, compilerService, haxeVersion) | ||
{ | ||
} | ||
|
||
protected override void SaveFile() | ||
{ | ||
foreach (var document in PluginBase.MainForm.Documents) | ||
{ | ||
if(document.FileName != Sci.FileName && document.IsModified) document.Save(); | ||
} | ||
} | ||
|
||
protected override string[] BuildHxmlArgs() | ||
{ | ||
var args = base.BuildHxmlArgs(); | ||
if (args == null) return null; | ||
var list = new List<string>(args) {"-D display-stdin"}; | ||
var result = list.ToArray(); | ||
return result; | ||
} | ||
|
||
protected override string GetFileContent() | ||
{ | ||
return Sci.Text; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there any possible filesize concern here? What about if you're editing a very large file? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My test file contains more than 20,000 lines of text and all ok) |
||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe do a semver greater-than-or-equal 3.3.0 if it's possible; who knows, a 3.2.2 fix release could happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 7c68005