Exclude tests from wheel #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v2.1.1 has been released on PyPI |
|
Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Came across this library as a dependency of https://github.com/strictdoc-project/strictdoc. I noticed that the tests for this library are distributed inside the wheel. Unfortunately this breaks test integrations for some users of the library since a number of Python tools detect the
site-packages/testsdirectory provided bypython_datauriin the virtual environment before the local projecttestsdirectory.Would you be open to removing the tests from distribution in the wheel? Looks like a pretty simple change to
setup.py. Happy to help make this happen. If you're willing to publish a new version with this change I will also open a PR with StrictDoc to use the new version.Without this change the workaround I'm stuck with is to
rm -rfthetestsfolder in the virtual environment after installation which is less than ideal.Thanks!