Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tag parse error(support \ in value) #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix tag parse error(support \ in value) #49

wants to merge 2 commits into from

Conversation

zhangyu-seven
Copy link

@zhangyu-seven zhangyu-seven commented Aug 31, 2021 •
edited
Loading 

rTags    = regexp.MustCompile(`[\w_]+:"[^"]+"`)

don't support escape character \

@zhangyu-seven
Copy link
Author

I have found some bugs in the code，i want to fix these first

@coveralls
Copy link

coveralls commented Sep 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 83

  • 38 of 39 (97.44%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.3%) to 75.229%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parse.go 38 39 97.44%
Totals Coverage Status
Change from base Build 80: 3.3%
Covered Lines: 164
Relevant Lines: 218
💛 - Coveralls

@zhangyu-seven
Copy link
Author

@favadi please review the code

@zhangyu-seven zhangyu-seven mentioned this pull request Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangyu-seven @coveralls