Add fetch option

[BrunoQuaresma]

No description provided.

[BrunoQuaresma]

Related to: #207

[danieltodonnell]

Code-wise, this looks great, but we should NOT merge this into the main code-base until we have some major users test it out first. We had issues previously with dynamically required libraries, and I only want to prerelease this until we do thorough testing.
NO MERGE YET.

[BrunoQuaresma]

@danieltodonnell the dynamic requires was solved. We are already doing that on

faunadb-js/src/Client.js

Line 86 in 1901da3

? require('https')

[dihmeetree]

Code-wise, this looks great, but we should NOT merge this into the main code-base until we have some major users test it out first. We had issues previously with dynamically required libraries, and I only want to prerelease this until we do thorough testing.
NO MERGE YET.

I can do some debugging on this myself, and let you know if it works well or not!

[BrunoQuaresma]

@lolcoolkat I would love that. Thanks!

[dihmeetree]

So I got it working inside my Cloudflare Worker by doing the following:

client: new faunadb.Client({
  secret,
  fetch: (req, init) => fetch(req, init),
})

Note: Passing fetch directly as a parameter gave me a TypeError: Illegal invocation error.

The only problem was that there seem's to be an issue with the following code, which gives me a TypeError: t.entries(...).forEach is not a function error.

faunadb-js/src/Client.js

Line 189 in 1901da3

responseHeadersAsObject(response),

Removing this line makes the FaunaDB client work fine again :) (However i'm sure that it definitely does something important :P)

[BrunoQuaresma]

Thanks @lolcoolkat for the help on this.

1. fetch: (req, init) => fetch(req, init) does not sound right.
2. I'll check why the .entries().forEach is returning is not a function.

[mpavlinsky]

I am also trying to get this working on cloudflare workers so I happen to have some answers:

1. On cloudflare you can get the properly bound fetch with fetch.bind(globalThis)
2. The fetch headers entries are an 'Iterator' not an array-like (https://developer.mozilla.org/en-US/docs/Web/API/Headers/entries) so I think the fallback iteration needs to change to something like

 var iter = responseHeaders.entries();
    var current;
    do {
      current = iter.next();
      if (current.value) {
        headers[current.value[0]] = current.value[1];
      }
    } while (!current.done);

(Or whatever the accepted way of iteration is in ES5, I assume we can't for ... of)

[dihmeetree]

Thank you @mpavlinsky !! Doing the following:

new faunadb.Client({
    secret,
    fetch: fetch.bind(globalThis),
})

seem's to do the trick! And for your # 2 that info is helpful. Thanks!

[BrunoQuaresma]

@mpavlinsky do you know if there is any doc related to the fetch() API used by CloudFlare Worker? I'm trying to understand why it is diff of the "standard" web API and if there is another differences to add in the tests to avoid future incompatibilities.

[mpavlinsky]

https://developers.cloudflare.com/workers/reference/apis/fetch/

Regarding the headers I think that is the behavior of the standard fetch. In my browser console fetch('https://google.com', {mode: 'no-cors'}).then(r => console.log(r.headers.entries().forEach)); returns undefined.

[BrunoQuaresma]

@lolcoolkat @mpavlinsky can you check if the last commit fixes the forEach() issue?

[dihmeetree]

@lolcoolkat @mpavlinsky can you check if the last commit fixes the forEach() issue?

Works perfectly! Thanks for the fix :)

[mpavlinsky]

I believe we want a test that exercises headers as an Iterator as is the case when using browser fetch

[BrunoQuaresma]

The Iterator is returned by the entries(). The headers options are type of Headers[] which have a similar API with the Headers object. I used Set() to avoid extra mocking.

Headers ref: https://developer.mozilla.org/en-US/docs/Web/API/Headers/Headers

[BrunoQuaresma]

Beta version published on https://www.npmjs.com/package/faunadb/v/2.11.2-beta