Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config] component verbose logger leaks secrets #590

Closed
echo-bravo-yahoo opened this issue Feb 5, 2025 · 1 comment
Closed

[config] component verbose logger leaks secrets #590

echo-bravo-yahoo opened this issue Feb 5, 2025 · 1 comment

Comments

@echo-bravo-yahoo
Copy link
Collaborator

echo-bravo-yahoo commented Feb 5, 2025 •
edited
Loading

none of the verbose loggers should expose secrets - there's an existing pattern for redacting these, and we should apply it here, too.
echo-bravo-yahoo added a commit that referenced this issue Feb 5, 2025
@echo-bravo-yahoo
redact config entries to prevent leaking secrets through verbose logg…
32891c1 
…ing #590
@echo-bravo-yahoo echo-bravo-yahoo mentioned this issue Feb 5, 2025
Merged
echo-bravo-yahoo added a commit that referenced this issue Feb 5, 2025
@echo-bravo-yahoo
redact config entries to prevent leaking secrets through verbose logg…
806d545 
…ing #590
echo-bravo-yahoo added a commit that referenced this issue Feb 5, 2025
@echo-bravo-yahoo
redact config entries to prevent leaking secrets through verbose logg…
49016eb 
…ing #590 (#591)
@echo-bravo-yahoo
Copy link
Collaborator Author

closed by #591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@echo-bravo-yahoo