Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add score to report #998

Merged
merged 4 commits into from
Oct 25, 2024
Merged

add score to report #998

merged 4 commits into from
Oct 25, 2024

Conversation

noursaidi
Copy link
Collaborator

Example:

## Summary

| | Feature | Alpha |
| --- | --- | --- |
| - | discovery.scan | 10/10 |
| - | endpoint.config | 10/10 |


## Results

| Bucket | Feature | Stage | Score | Result | Description |
| --- | --- | --- | --- | --- | --- |
| discovery.scan | single_scan_future | alpha | 10 | pass | Sequence complete |
| endpoint.config | endpoint_connection_bad_hash | alpha | 10 | pass | Sequence complete |

@noursaidi noursaidi requested a review from grafnu October 23, 2024 16:37
grafnu
grafnu approved these changes Oct 23, 2024
View reviewed changes
bin/sequencer_report Outdated
@dataclass(unsafe_hash=True, eq=True, order=True)
def sanitize(string: str):
"""Sanitize string for safe displaying"""
sanitized = string.replace("\n", ";")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually I'd be replacing with a "; " (space after semicolon... not sure that works here, tho)

@noursaidi noursaidi merged commit ad2b7fe into faucetsdn:master Oct 25, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafnu grafnu grafnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noursaidi @grafnu