Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing for hidden or temporary device files #599

Merged
merged 4 commits into from
Feb 28, 2023

Conversation

grafnu
Copy link
Collaborator

@grafnu grafnu commented Feb 27, 2023

Addresses situations where there's a hidden folder in the devices/ directory (e.g. .DS_store from mac) and/or temporary edit files (i.e. trailing ~). Filters them out so they're not considered valid "devices" for the tools.

@grafnu grafnu marked this pull request as draft February 27, 2023 17:09
@grafnu grafnu marked this pull request as ready for review February 27, 2023 18:00
Copy link
Collaborator

@johnrandolph johnrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please describe the scenario this fixes in the comments of this PR?
Also the generic variable name...

@grafnu grafnu merged commit 5ba81c9 into faucetsdn:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants