Adding provision to clean out alternate config #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrandolph
requested changes
Feb 14, 2023
| @@ -1242,8 +1240,19 @@ protected void withAlternateClient(Runnable evaluator) { | |||
| } | |||
| } | |||
|
|
|||
| protected void mirrorDeviceConfig() { | |||
| String receivedConfig = actualize(stringify(receivedUpdates.get(CONFIG_SUBTYPE))); | |||
| protected void mirrorToOtherConfig() { | |||
There was a problem hiding this comment.
Could we have some line by line comments here? It's getting fairly dense...
| } | ||
|
|
||
| protected void clearOtherConfig() { | ||
| updateMirrorConfig("{}"); |
There was a problem hiding this comment.
Comments please. Should this run in all conditions or are there any useful assertions to add that help document what's going on.
There was a problem hiding this comment.
I don't know what assertions to add -- I added one to make sure the client was setup correctly, but if that was the case it would have had a horrible NPE anyway -- it's just a bit more clear.
|
Updated with comments. |
johnrandolph
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nukes the not-in-use config to prevent it inadvertently being used to bounce around from a not-used endpoint.