Adding alternate registry endpoint redirection test #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| untilTrue("blobset phase is FINAL and stateStatus is null", () -> { | ||
| private void untilSuccessfulRedirect(BlobPhase blobPhase) { |
There was a problem hiding this comment.
Move helper functions to the top above tests?
| && blobStateStatus == null; | ||
| }); | ||
| } | ||
|
|
||
| private void setDeviceConfigEndpointBlob(String googleEndpointHostname, String registryId) { |
| this::stateMatchesConfigTimestamp); | ||
| untilClearedRedirect(); | ||
|
|
||
| // Phase three: initiate connection back to initial registry. |
There was a problem hiding this comment.
This ends up testing connection to the alternate registry, plus connecting back ("restoration"), so two tests.
I assume this is just so the device isn't altered by the test, so can we comment a rationale at either step 3 or 4.
| @@ -79,31 +74,76 @@ public void endpoint_config_connection_error() { | |||
| } | |||
There was a problem hiding this comment.
untilClearedRedirect() here?
johnrandolph
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.