Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop on CIs after Numba v0.5.0 #180

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Fix infinite loop on CIs after Numba v0.5.0 #180

merged 3 commits into from
Jul 20, 2020

Conversation

santisoler
Copy link
Member

@santisoler santisoler commented Jul 20, 2020

Set NUMBA_THREADING_LAYER to workqueue on Travis CIs running Ubuntu.
Solution obtained from numba/numba#5983.

Reminders:

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and the base __init__.py file for the package.
  • Write detailed docstrings for all functions/classes/methods. It often helps to design better code if you write the docstrings first.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.
  • Add your full name, affiliation, and ORCID (optional) to the AUTHORS.md file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.

@santisoler santisoler added the bug Report a problem that needs to be fixed label Jul 20, 2020
@santisoler
Copy link
Member Author

@leouieda Using NUMBA_THREADING_LAYER=workqueue fixed the problem on Travis CI.
But, the CIs will still fail building the docs because of #174. Do you agree to merge this PR even CIs are failing?
I will then update #173, where hopefully CIs will work flawlessly.

@santisoler santisoler requested a review from leouieda July 20, 2020 13:05
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santisoler yeah, I'm fine with merging this in 👍🏽

@santisoler
Copy link
Member Author

Awesome! Now I can put CIs back on the rails!

@santisoler santisoler merged commit e259654 into master Jul 20, 2020
@santisoler santisoler deleted the numba-on-ci branch July 20, 2020 14:02
santisoler added a commit that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report a problem that needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants