Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use verbose output from Fastly CLI #2

Merged
merged 1 commit into from
Mar 5, 2021
Merged

Use verbose output from Fastly CLI #2

merged 1 commit into from
Mar 5, 2021

Conversation

kailan
Copy link
Member

@kailan kailan commented Mar 5, 2021 •
edited
Loading

This resolves the issue of the progress spinner filling up the logs.

@kailan kailan requested review from a team and Integralist and removed request for a team March 5, 2021 12:22
Integralist
Integralist approved these changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit paradoxical but looking at the CLI code it would appear using the verbose flag is (for CI) an easy way to avoid so much log noise as it won't attempt to utilize a spinner like with NewQuietProgress does.

Nice spot 👍🏻

@kailan kailan merged commit 92417c0 into beta Mar 5, 2021
@kailan kailan deleted the verbose-output branch March 5, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kailan @Integralist