fix(all commands): --service-name flag should have priority. #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename FlagServiceDesc to FlagServiceNameDesc to be consistent with FlagServiceID/FlagServiceIDDesc.
When the --service-name flag was added it was given the lowest priority for obtaining a service ID. If a user supplied this flag but also supplied --service-id, or had a fastly.toml with a service ID in it, or had the FASTLY_SERVICE_ID environment variable set, the --service-name flag would be ignored. This resulted in a user accidentally deleting a service because the flag was ignored. This commit changes the priority so that --service-name and --service-id have equal (top) priority, and also ensures that supplying both will result in an error. It also adds a unit test for the argparser.ServiceID() function which implements this logic. Closes fastly#1261.
jsocol
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the --service-name flag was added it was given the lowest
priority for obtaining a service ID. If a user supplied this flag but
also supplied --service-id, or had a fastly.toml with a service ID in
it, or had the FASTLY_SERVICE_ID environment variable set, the
--service-name flag would be ignored. This resulted in a user
accidentally deleting a service because the flag was ignored.
This commit changes the priority so that --service-name and
--service-id have equal (top) priority, and also ensures that
supplying both will result in an error. It also adds a unit test for
the argparser.ServiceID() function which implements this logic.
Closes #1261.