fix(kvstore): delete all keys

[Integralist]

This PR fixes the performance issues with deleting all keys from a KV Store and requires https://github.com/fastly/go-fastly/releases/tag/v9.3.1

This PR also adds support for configuring the deletion of keys via the fastly kv-store delete --all command (as customers didn't expect to find that behaviour inside of fastly kv-store-entry delete --all)

[cee-dub]

I don't see anything obviously wrong with this code, so my suggestion is to profile it and see what's taking the most time. Maybe there's something blocking that is hard to spot when reading but will be obvious in a profile.

[Integralist]

@cee-dub this is ready for a re-review. Thanks

[cee-dub]

For 10k keys, the delete operation is now faster than bulk load. Bravo!

[dennismartensson]

I am not sure this is deciereble. We have made the decision to not allow wholesale deletion of of stores. This feels like a bit of a work around to that decision and is probably worst then what we could do if we allow wholesale deletes.

[cee-dub]

@dennismartensson I'm aware of some discussions about not allowing wholesale deletes. There are customer requests for this feature to exist, e.g. for CI environments. Do you have any ideas how to address those customer requests without this? I agree this solution is a workaround, but that's the result of the decision not to allow wholesale deletion of KV stores.

[dennismartensson]

I am just worried that a developer fat fingers a delete of a store with millions of objects or TB of data and we have no way of recovering that for them it is just gone and might take them a very long time to recover.

[Integralist]

I am just worried that a developer fat fingers a delete of a store with millions of objects

Just as a side note this 'delete all keys' feature has existed in the CLI for a while now (~10 months without issue).

We already present the following warning prompt to the user before the deletion process is started...

And in this PR I've added a similar warning for the fastly kv-store delete command...

[dennismartensson]

Okay good thank you. *Dennis Mårtensson* | Director of Engineering - Edge Data fastly.com | @fastly <https://twitter.com/fastly> | LinkedIn <http://www.linkedin.com/company/fastly>

…

On Thu, 18 Apr 2024 at 10:29, Mark McDonnell ***@***.***> wrote: I am just worried that a developer fat fingers a delete of a store with millions of objects Just as a side note this 'delete all keys' feature has existed in the CLI for a while now (~10 months without issue). We already present the following warning prompt to the user before the deletion process is started... Screenshot.2024-04-18.at.09.27.00.png (view on web) <https://github.com/fastly/cli/assets/180050/2e3ea192-cdf5-47e7-9571-7e5a12607c99> And in this PR I've added a similar warning for the fastly kv-store delete command... Screenshot.2024-04-18.at.09.28.20.png (view on web) <https://github.com/fastly/cli/assets/180050/4eb40b57-c604-49f9-bc6c-60ec2624eb55> — Reply to this email directly, view it on GitHub <#1181 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFBUKL62PJWOEVHJ4VLG5LY56AANAVCNFSM6AAAAABGJWGZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTGMYTQMZXHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>