Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stats/historical): avoid runtime SIGSEGV #1169

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix(stats/historical): avoid runtime SIGSEGV #1169

merged 2 commits into from
Mar 27, 2024

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Mar 27, 2024 •
edited
Loading

CLI was triggering a SIGSEGV panic whenever a flag was being passed (like --from, regardless of value)...

go run cmd/fastly/main.go stats historical --service-id <SOME_ID> --token $FASTLY_API_KEY --from '2024-03-20 12:00:00'

The fix was to change how the Kingpin package writes the flag value to memory.

@Integralist Integralist added the bug Something isn't working label Mar 27, 2024
kpfleming
kpfleming approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@kpfleming kpfleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straightforward to me, if you've verified that it resolves the bug then we're off and running.

@Integralist Integralist merged commit a20e03c into main Mar 27, 2024
6 checks passed
@Integralist Integralist deleted the integralist/fix-historical-stats branch March 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpfleming kpfleming kpfleming approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @kpfleming