Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(compute/pack): use package name from manifest #1025

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Sep 29, 2023

The fastly compute deploy command expects the package file to be named the same as the name attribute in the fastly.toml manifest. The fastly compute pack command does not do this, it instead names the package file package.tar.gz and consequently this causes the deploy command to fail.

NOTE: It was probably assumed that if a user was using compute pack they might not be using the CLI for developing an application, so we shouldn't expect them to have a fastly.toml manifest present. In this PR we presume a manifest is present by default and fallback to using package.tar.gz otherwise.

@Integralist Integralist added the bug Something isn't working label Sep 29, 2023
@Integralist Integralist force-pushed the integralist/pack-name branch from 68fd062 to 062830a Compare October 2, 2023 16:44
@Integralist Integralist changed the title fix(compute/pack): use package name breaking(compute/pack): use package name from manifest Oct 3, 2023
@Integralist Integralist force-pushed the integralist/pack-name branch 4 times, most recently from 19f6b0b to a93fdbe Compare October 12, 2023 16:29
@Integralist Integralist force-pushed the integralist/pack-name branch 3 times, most recently from 794bc97 to c423a7e Compare October 18, 2023 11:54
@Integralist Integralist force-pushed the integralist/pack-name branch 2 times, most recently from ce6b9cc to a6d52a8 Compare October 25, 2023 13:17
@Integralist Integralist force-pushed the integralist/pack-name branch 4 times, most recently from 6de0e40 to 7caf5e7 Compare November 9, 2023 14:57
@Integralist Integralist force-pushed the integralist/pack-name branch 2 times, most recently from 9eb4f6a to e08bc8b Compare November 16, 2023 11:33
@Integralist Integralist force-pushed the integralist/pack-name branch from e08bc8b to b4ea655 Compare November 28, 2023 11:47
@anthony-gomez-fastly anthony-gomez-fastly requested a review from a team as a code owner March 25, 2025 19:19
@anthony-gomez-fastly anthony-gomez-fastly self-requested a review March 25, 2025 19:19
@anthony-gomez-fastly anthony-gomez-fastly merged commit 0cae940 into main Mar 25, 2025
12 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the integralist/pack-name branch March 25, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants