Allow host overrides in TOML configuration #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
reviewed
Jul 19, 2021
There was a problem hiding this comment.
🙌 🥳 Woohoo! Thanks for taking this issue on @fgsch, this all looks wonderful! I have two very small nitpicks to address, one concerning a use import, and a one-line alteration to our new integration test.
Hopefully, this should all be addressable from the web UI, and we can get this landed soon!
|
I've rebased this PR to fix the via_hyper() commit and drop the commit that was cherry-picked in #49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new field to the backend definition, override_host,
allowing to override the Host header that will be sent to the
backend.
Addresses #9.