🧹 Tidy up logging and error output #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
variant for unavailable features.
phamann
reviewed
Jul 15, 2021
lib/src/execute.rs
Outdated
| Level::INFO, | ||
| "Request completed, using {} bytes of wasm heap", | ||
| info!( | ||
| "request completed using {} bytes of WebAssembly heap", |
There was a problem hiding this comment.
Maybe a future improvement and out of scope of this PR, however, it would be nice if the n bytes could be a more human-friendly representation I.e. 1 Kb, 1Mb, 1Gb etc. Such as bytesize.
There was a problem hiding this comment.
Sounds great, I'll try to sneak that one in as well!
There was a problem hiding this comment.
Alright, I added a commit to make the heap size human-friendly, thank you!
mgattozzi
approved these changes
Jul 15, 2021
cratelyn
approved these changes
Jul 15, 2021
cratelyn
added
logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few minor UI nits (reported on Slack), as well as a more significant issue: rather than panicking when an unimplemented hostcall is used, we instead yield an error back to the guest. The error reporting infrastructure will print a friendly message, though in most cases the SDK will subsequently panic.