Replace mandatory extension with validation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgsch
force-pushed
the
remove-ext-restriction
branch
from
15ef9a6 to
3178b71
Compare
Rather than restricting the extension to .wasm and later failing when loading the file, accept any file but validate its content. As a bonus, disambiguate OS specific errors (e.g., file does not exist) from invalid format. Fixes fastly#2.
fgsch
force-pushed
the
remove-ext-restriction
branch
from
3178b71 to
e98ddd5
Compare
aturon
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than restricting the extension to .wasm and later failing when loading the file, accept any file but validate its content.
As a bonus, disambiguate OS specific errors (e.g., file does not exist) from invalid format.
Fixes #2.