Revamp profile handling CLI flags #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
fgsch/add-perfmap
branch
from
f1a1e9f to
839bcc2
Compare
JakeChampion
reviewed
Oct 6, 2023
Comment on lines
-51
to
-55
| /// Whether to profile the wasm guest. Takes an optional directory to save | ||
| /// per-request profiles to | ||
| #[arg(long, default_missing_value = "guest-profiles", num_args=0..=1, require_equals=true)] | ||
| profile_guest: Option<PathBuf>, | ||
|
|
There was a problem hiding this comment.
Note: This would be a breaking change as we are removing a flag, we'd need to version accordingly -- I don't think we've made an intentional breaking change in this project before. We should mention the breaking change in the CHANGELOG.md file and if possible, write up a guide on what the migration path is for this feature
fgsch
force-pushed
the
fgsch/revamp-profiling-opts
branch
from
9b4b774 to
c992023
Compare
Merged
JakeChampion
reviewed
Oct 6, 2023
--profiler becomes --profile.
Add help verbiage for --profile.
fgsch
force-pushed
the
fgsch/revamp-profiling-opts
branch
from
c992023 to
9da618f
Compare
JakeChampion
approved these changes
Oct 9, 2023
JakeChampion
changed the title
cmckendry
pushed a commit
to 1stdibs/Viceroy
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves profiling to
--profile, and replaces--profile-guest=[path]in favour of--profile=guest[,path], unifying the profiling options (and matching Wasmtime). Most of the code is adapted from Wasmtime.While here I've removed some unncessary lifetimes and polished the code, mostly courtesy of clippy (the 2 last commits).
The PR is related to and was built on top of #316. It might make sense to review that one first.