⏩ none should not be defined in cache_override_tag witx #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ABI expects `$none` to have a value of 0, and `$pass` to have a value of 1. However, flags in witx start with a value of 1. Putting `$none` in the list erroneously defines it to have a value of 1. Fastly's SDKs do things correctly, but tools like https://github.com/jedisct1/witx-codegen which generate bindings from witx will generate code that is off by one bit position.
JakeChampion
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ABI expects
$noneto have a value of 0, and$passto have avalue of 1. However, flags in witx start with a value of 1. Putting
$nonein the list erroneously defines it to have a value of 1.Fastly's SDKs do things correctly, but tools like https://github.com/jedisct1/witx-codegen
which generate bindings from witx will generate code that is off by one
bit position.