Remove validation on config store and dictionary names #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation rules for names of Config Stores and Dictionaries are different. Config Stores have very relaxed rules, the name can contain any character, even just whitespace characters. This patch removes the validation rules for names, this does mean an invalid Dictionary name could be used locally, but the customer will see the issue when they deploy to Fastly Compute
JakeChampion
force-pushed
the
jake/config-stores-names
branch
from
17072ef to
c161b68
Compare
dennismartensson
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation rules for names of Config Stores and Dictionaries are different. Config Stores have very relaxed rules, the name can contain any character, even just whitespace characters.
This patch removes the validation rules for names, this does mean an invalid Dictionary name could be used locally, but the customer will see the issue when they deploy to Fastly Compute