🪀 Add fastly_backend interfaces for backend introspection
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resilience in the face of future changes.
|
There might be a good reason to keep the flag check: Viceroy is often used for testing SDK implementations, and having feedback about invalid flags could be invaluable for debugging. wdyt? |
…support resilience in the face of future changes." This reverts commit c83f757.
|
Well, OK. I was going to argue a bit, but then we discovered that we were a few functions behind in the backend introspection API, and that this was going to cause problems. Which then made me think "well, that means we can't be super tolerant of unknown things in general", so ... OK, agreed. Also, this PR just got bigger. Sorry for the surprise embiggening. |
cratelyn
approved these changes
Mar 22, 2023
cratelyn
changed the title
fastly_backend interfaces for backend introspection
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually implement any interesting functionality -- it's not clear what pooling would mean within the context of Viceroy -- but it allows programs that use this flag to function properly.
Because this just bit me, I've also removed the bit of code that checks for unknown flags and errors. I think it actually makes more sense for old versions of Viceroy to ignore flags they don't understand. Admittedly, I'm betting that future changes will be like this one (in that they don't change any, or change very little, Viceroy behavior), and not settings which will totally change behavior.