Update fastly_status witx definition to include the new limitexceeded variant #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variant This variant is returned when an attempt to allocate a resource has exceeded the maximum number of resources permitted. For example, creating too many response handles or makiing too many dictionary lookups.
acfoltzer
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Looks good, although we typically wouldn't merge an ABI update until it is supported across the fleet. In this case we probably can merge sooner as it is backwards compatible with existing SDKs... we should probably have a more explicit set of criteria for handling these types of changes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variant is returned when an attempt to allocate a resource has exceeded the maximum number of resources permitted. For example, creating too many response handles or makiing too many dictionary lookups.