Return a FastlyStatus::Inval when opening a non-existant object-store #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
force-pushed
the
jake/missing-object-store
branch
from
01c89fe to
f89ad88
Compare
|
This fixes the issue I was having with the Go SDK. |
JakeChampion
force-pushed
the
jake/missing-object-store
branch
from
f89ad88 to
0123293
Compare
mgattozzi
approved these changes
Nov 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we return an invalid handle, which seems to be different behavior than what I am seeing on C@E -- I've updated the implementation to match what I see on C@E, which is to return FastlyStatus::Inval