-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access global Buffer conditionally #15
Conversation
Would you mind to add a unit test? |
I could try. Could you assure me you agree with the premise to make the package run in the browsers? I expect we’ll need additional testing tooling beyond what the project already has. Do you have preferences, are you particularly opinionated about it? |
I have used airtap in the past and it works really well. |
0ae5342
to
0bb2f18
Compare
Enables to run the code in environments where the global Buffer is undefined, i.e. in the browsers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mcollina, please release 2.3.0 at your convenience for us to enjoy the browser compatibility. Other outstanding PRs are non-functional from the user’s point of view. |
Enables to run the code in environments where the global Buffer is undefined, i.e. in the browsers.
Related issue: #14
Checklist
npm run test
andnpm run benchmark
and the Code of conduct