Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace typeof undefined check #272

Merged
merged 2 commits into from
Oct 29, 2023
Merged

test: replace typeof undefined check #272

merged 2 commits into from
Oct 29, 2023

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 28, 2023

See fastify/fastify-helmet#236

Checklist

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 29, 2023

Test failures unrelated.

@Fdawgs Fdawgs requested a review from a team October 29, 2023 11:16
@Uzlopak
Copy link
Contributor

Uzlopak commented Oct 29, 2023

To trigger the WFs I modified your PR "significantly".

@Fdawgs Fdawgs merged commit ba185e8 into master Oct 29, 2023
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch October 29, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fdawgs @Uzlopak