Fix file matching when dot appears before extension #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Nov 25, 2018
cemremengu
force-pushed
the
fix-fileregex
branch
from
46d78ea to
f01e0b9
Compare
mcollina
approved these changes
Nov 27, 2018
test/stackParser.test.js
Outdated
|
|
||
| const anonymousStack = `Unable to parse this` | ||
|
|
||
| test('should extract plugin name correctly from stack', t => { |
There was a problem hiding this comment.
nit: I don't think there is the need here to use test.
There was a problem hiding this comment.
Sorry, can you elaborate a bit? You mean it should be t.test ?
There was a problem hiding this comment.
you can completely remove the t.test part, the script will work anyway.
There was a problem hiding this comment.
Thanks, I didn't know it could be used like that 👍
There was a problem hiding this comment.
@mcollina let me me know if this is ok to patch in when you have time
|
Lacking permissions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53
I didn't know how to add a unit test for this. Any ideas are appreciated.
There might be better ways to solve this as well.